Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Revert "Add StreamingContext public APIs back to contract" #10707

Merged
merged 2 commits into from
Aug 12, 2016

Conversation

weshaggard
Copy link
Member

Reverts #10036

These APIs modified APIs in a frozen netstandard (see https://github.com/dotnet/corefx/issues/10426). In particular it added APIs to the ref targeting netstandard1.3 which isn't compatible. If we want to add these we need to correctly version them and put them in a new netstandard. For now I don't believe we need them so I'm reverting this change. We can include as part of the work we are doing in dev/api. See PR #10667.

FYI @joperezr @stephentoub @danmosemsft

@joperezr
Copy link
Member

I'm not sure I understand how are these not breaking changes?

@weshaggard
Copy link
Member Author

@joperezr your not sure how this isn't breaking or why the original change was breaking? The original change was breaking because it added APIs to netstandard versions that were already frozen which isn't allowed as anyone building and using these new APIs would expect existing shipped platforms like .NET core 1.0 to support them which they don't.

I agree that this change itself will likely cause some break in corefx for any components that may be referencing this higher assembly/package version but we need to fix those.

@joperezr
Copy link
Member

I see, sounds good.

@joperezr
Copy link
Member

LGTM

weshaggard and others added 2 commits August 11, 2016 22:20
We are reverting tht 4.2.0 changes for S.R.S.Primitves so we need
to move these test to the last table version of 4.1.1
@weshaggard weshaggard force-pushed the revert-10036-streamingcontext branch from b495214 to 19c1a45 Compare August 12, 2016 05:22
@weshaggard weshaggard merged commit 6d8e449 into master Aug 12, 2016
@jkotas jkotas deleted the revert-10036-streamingcontext branch August 12, 2016 22:38
@karelz karelz modified the milestone: 1.1.0 Dec 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants