This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Move serialization primitives to System.Runtime #10667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2016
joperezr
force-pushed
the
move_serialization_primitives
branch
from
36477d5 to
b66158e
Compare
joperezr
force-pushed
the
move_serialization_primitives
branch
from
b66158e to
5ab7b3d
Compare
| Debug.Assert(null != name, "[SerializationInfo.UpdateValue]name!=null"); | ||
| Debug.Assert(null != value, "[SerializationInfo.UpdateValue]value!=null"); | ||
| Debug.Assert(null != type, "[SerializationInfo.UpdateValue]type!=null"); | ||
| //Debug.Assert(null != name, "[SerializationInfo.UpdateValue]name!=null"); |
There was a problem hiding this comment.
Why are these asserts commented out?
There was a problem hiding this comment.
As per the original PR message written by @stephentoub:
Debug.Assert is not currently available in System.Runtime. Asserts have been commented out with TODOs.
| @@ -4,15 +4,17 @@ | |||
| <PropertyGroup> | |||
| <AssemblyName>System.Runtime.Serialization.Primitives</AssemblyName> | |||
| <AssemblyVersion>4.2.0.0</AssemblyVersion> | |||
There was a problem hiding this comment.
FYI - I've reverted some of the versioning changes to this library in master see PR #10707. We will need to handle that merge accordingly.
There was a problem hiding this comment.
Ok, yeah I'll fix the merge conflicts.
|
A few minor comments but otherwise looks good. |
joperezr
force-pushed
the
move_serialization_primitives
branch
4 times, most recently
from
b77e750 to
3768b22
Compare
We need BinaryFormatter to be able to serialize types from coreclr that use the various serialization types (e.g. ISerializable), which means those types must have the same identity as the ones BinaryFormatter recognizes, and we need a bunch of types all across corefx to be able to use these same types to implement serialization. As such, the types are moving down to System.Runtime, and on coreclr, are type-forwarding to the implementations there. There are a few outstanding issues: - SR is not currently available in System.Runtime. The few uses of SR in the versions of the code used for corert have been replaced by hardcoded strings and TODOs. - Debug.Assert is not currently available in System.Runtime. Asserts have been commented out with TODOs. - To get things to build as types are moving around, P2P references are used.
joperezr
force-pushed
the
move_serialization_primitives
branch
from
3768b22 to
17aa557
Compare
|
Thanks for finishing this, @joperezr. |
4 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…on_primitives Move serialization primitives to System.Runtime Commit migrated from dotnet/corefx@a9ab503
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @weshaggard @stephentoub
replaces: #10388
This PR takes the old one that @stephentoub started, and finishes it by updating the packages correctly in order to have the right surface area for each
TargetGroup.Original PR message: