This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Move String.Comparison.cs to shared CoreLib partition #17247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
reviewed
Mar 27, 2018
| // We want to ensure we can change our hash function daily. | ||
| // This is perfectly fine as long as you don't persist the | ||
| // value from GetHashCode to disk or count on String A | ||
| // hashing before string B. Those are bugs in your code. |
There was a problem hiding this comment.
Shame to loose this amazing comment 😄
benaadams
approved these changes
Mar 27, 2018
|
@Anipik Could you please check why this was missed by CoreCLR->CoreRT mirror? |
|
I have started mirror for it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.