Moves String.Comparison.cs to shared location #17035
Conversation
| internal static extern unsafe int nativeCompareOrdinalIgnoreCaseWC(String strA, sbyte* strBBytes); | ||
|
|
||
| [MethodImplAttribute(MethodImplOptions.InternalCall)] | ||
| private static extern int InternalMarvin32HashString(string s); |
There was a problem hiding this comment.
I noticed. I think moving whole GetHashCode (+deps) to String.CoreCLR.cs is best here
There was a problem hiding this comment.
Why? It is same between CoreCLR and CoreRT.
| //This will not work in case-insensitive mode for any character greater than 0x7F. | ||
| //We'll throw an ArgumentException. | ||
| [MethodImplAttribute(MethodImplOptions.InternalCall)] | ||
| internal static extern unsafe int nativeCompareOrdinalIgnoreCaseWC(String strA, sbyte* strBBytes); |
There was a problem hiding this comment.
Taking care of this one in #17061
|
There will be more changes necessary to make the shared implementation build and work well under both CoreCLR and CoreRT. |
marek-safar
force-pushed
the
string-fixes
branch
from
617a0c4 to
ab94f87
Compare
marek-safar
force-pushed
the
string-fixes
branch
from
ab94f87 to
1cf8cc1
Compare
|
The shared implementation has only managed code and it should work everywhere. CoreRT already has |
|
@jkotas what remains here? |
|
It needs to build and work in CoreRT/ProjectN. I have been working through the issues to make it work well. I think we can close this one since it has conflicts. I will take care of submitting PR with the required changes. |
|
Superseded by #17247 |
No description provided.