This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
JIT: tolerate nonzero constant byrefs in impCheckForNullPointer #17042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the advent of dotnet#16966 we may now see constant nonzero byrefs from things like RVA statics. Tolerate these in `impCheckForNullPointer`. Note previously we'd type these as ints/longs and so bail out of `impCheckForNullPointer` after the first check. Closes #17008.
|
@BruceForstall PTAL |
|
@dotnet-bot test Windows_NT x86 Checked Build and Test |
|
Were there other pri-1 failure cases? I moved the offending test to pri-0 as part of this change. |
BruceForstall
approved these changes
Mar 19, 2018
briansull
approved these changes
Mar 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the advent of #16966 we may now see constant nonzero byrefs from
things like RVA statics. Tolerate these in
impCheckForNullPointer.Note previously we'd type these as ints/longs and so bail out of
impCheckForNullPointerafter the first check.Closes #17008.