This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
JIT: fix return type mismatch inline block for literal argument #16966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we inline a method that returns one of its arguments, we need to make sure to apply the callee's view of the argument type. We fixed this for arguments that are caller locals in dotnet#11218. This change applies similar logic to handle the case where the caller passes a literal constant. Closes #16944.
|
@briansull PTAL Don't expect any diffs from this -- will verify soon. |
|
Arm failure seems to be a known issue (#16961). I have verified this is no diff. |
|
Should this fix go into 4.7.3? |
|
I don't think it needs to be in 4.7.3. |
|
I build coreclr locally off this PR and confirmed that it produces correct code gen for the |
|
@briansull you ok with this change? |
AndyAyersMS
added a commit
to AndyAyersMS/coreclr
that referenced
this pull request
Mar 19, 2018
With the advent of dotnet#16966 we may now see constant nonzero byrefs from things like RVA statics. Tolerate these in `impCheckForNullPointer`. Note previously we'd type these as ints/longs and so bail out of `impCheckForNullPointer` after the first check. Closes #17008.
AndyAyersMS
added a commit
that referenced
this pull request
Mar 20, 2018
With the advent of #16966 we may now see constant nonzero byrefs from things like RVA statics. Tolerate these in `impCheckForNullPointer`. Note previously we'd type these as ints/longs and so bail out of `impCheckForNullPointer` after the first check. Closes #17008.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we inline a method that returns one of its arguments, we need to make sure
to apply the callee's view of the argument type.
We fixed this for arguments that are caller locals in #11218. This change applies
similar logic to handle the case where the caller passes a literal constant.
Closes #16944.