update nuget to 4.0.0-rc3 and sdk to 1.0.0-alpha-20170105-5 #5214
Conversation
|
@rohit21agrawal Updating the SDK requires a bunch of changes in the code because now the SDK has implicit globing. I am doing that in this PR here: #5212. |
|
@livarcocc could you incorporate these changes in your PR? the sdk has to be the version in this PR because nuget has had API changes and it will break for any other version of the sdk |
rohit21agrawal
force-pushed
the
ragrawal/updatenugetrc3
branch
from
313c4da to
c10ba0f
Compare
| @@ -1,9 +1,9 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <PropertyGroup> | |||
| <CLI_NETSDK_Version>1.0.0-alpha-20170105-5</CLI_NETSDK_Version> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| </PackageReference> | ||
| <PackageReference Include="Microsoft.Build.Utilities.Core"> | ||
| <Version>$(CLI_MSBuild_Version)</Version> | ||
| </PackageReference> | ||
| <PackageReference Include="Microsoft.Build.Framework"> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dotnet-bot test this please. |
|
Does this version of the SDK include dotnet/sdk#582? That PR fixes publishing on net46x, and based on the issues I'm tracking it'd help a lot of people if that PR makes it to a daily cli build. |
…tead of restore-projectjson command.
|
@dotnet-bot test Ubuntu x64 Release Build please |
…es an assets file on restore
rohit21agrawal
force-pushed
the
ragrawal/updatenugetrc3
branch
from
915fa94 to
fadf7c4
Compare
| @@ -4,7 +4,9 @@ | |||
| "debugType": "portable", | |||
| "emitEntryPoint": true | |||
| }, | |||
| "dependencies": {}, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@piotrpMSFT @livarcocc all changes made as per feedback. The CI is now building only as the result of adding the comment. all tests had already passed. can i go ahead and check this in? |
|
@rohit21agrawal I would prefer not. I particularly prefer merging things only when they are green. |
|
@dotnet-bot test Ubuntu x64 Release Build please |
|
@dotnet-bot test Ubuntu16.04 x64 Debug Build please |
|
@dotnet-bot Test Fedora23 x64 Debug Build |
updating nuget to 4.0.0-rc3 and sdk to 1.0.0-aplha-20170105-5. (This version of sdk was built with tests disabled)
CC: @livarcocc @rrelyea @eerhardt @piotrpMSFT