This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Updating the SDK to an SDK that includes globing for source and resources #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Jan 5, 2017
| @@ -2,8 +2,8 @@ | |||
| <Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <PropertyGroup> | |||
| <CLI_MSBuild_Version>15.1.0-preview-000458-02</CLI_MSBuild_Version> | |||
| <CLI_NETSDK_Version>1.0.0-alpha-20161230-1</CLI_NETSDK_Version> | |||
| <CLI_WEBSDK_Version>1.0.0-alpha-20161205-1-154</CLI_WEBSDK_Version> | |||
| <CLI_NETSDK_Version>1.0.0-alpha-20170104-3</CLI_NETSDK_Version> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
eerhardt
reviewed
Jan 5, 2017
| @@ -111,10 +111,10 @@ private AddPropertyTransform<CommonCompilerOptions>[] KeyFileTransforms | |||
| compilerOptions => compilerOptions.OutputName != null); | |||
|
|
|||
| private IncludeContextTransform CompileFilesTransform => | |||
| new IncludeContextTransform("Compile", transformMappings: false); | |||
| new IncludeContextTransform("Compile", false, ic => ic != null); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
eerhardt
reviewed
Jan 5, 2017
| @@ -4,6 +4,7 @@ | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>netcoreapp1.0</TargetFramework> | |||
| <Version>1.0.0-alpha</Version> | |||
| <EnableDefaultCompileItems>false</EnableDefaultCompileItems> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
eerhardt
approved these changes
Jan 5, 2017
…n't allow for having compile in the csprojs. We will have to update the CLI ones.
…grateBuildOptionsRule for clarity. Updating the tool project to use BuiltProjectOutputGroupOutput instead of content because of SDK issue dotnet/sdk#588
livarcocc
force-pushed
the
update_sdk_with_globbing
branch
from
96703dc to
72cd3d7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the SDK to an SDK that includes globing for source and resources implicitly.
@piotroko @piotrpMSFT @jonsequitur @eerhardt @krwq @jgoshi