Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off SDL validation #20691

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Turn off SDL validation #20691

merged 1 commit into from
Apr 10, 2020

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Apr 9, 2020

Based on the discussion here: dotnet/arcade#5219
Re-enabling tracked by #20690

Based on the discussion here: dotnet/arcade#5219
Re-enabling tracked by #20690
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 9, 2020
@pranavkm pranavkm requested review from dougbu, wtgodbe and Pilchie April 9, 2020 17:54
@ghost
Copy link

ghost commented Apr 9, 2020

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 53 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure an issue is filed to re-enable this or move it to another parallel pipeline?

@pranavkm
Copy link
Contributor Author

pranavkm commented Apr 9, 2020

@Pilchie already filed an issue to re-enable it: #20690

@wtgodbe
Copy link
Member

wtgodbe commented Apr 9, 2020

@pranavkm can you backport this to 3.1 as well?

@pranavkm
Copy link
Contributor Author

pranavkm commented Apr 9, 2020

Sure @wtgodbe. Could you use your magic build-admin powers to merge this in? We're investigating the Ubuntu failures, but it clearly could not be responsible for this failure

@wtgodbe wtgodbe merged commit 9cab3e2 into master Apr 10, 2020
@wtgodbe wtgodbe deleted the pranavkm-patch-2 branch April 10, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants