Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable SDL validation once timeout and failure issues are resolved #20690

Closed
pranavkm opened this issue Apr 9, 2020 · 3 comments
Closed

Re-enable SDL validation once timeout and failure issues are resolved #20690

pranavkm opened this issue Apr 9, 2020 · 3 comments
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Apr 9, 2020

pranavkm added a commit that referenced this issue Apr 9, 2020
@pranavkm
Turn off SDL validation
0589255 
Based on the discussion here: dotnet/arcade#5219
Re-enabling tracked by #20690
@pranavkm pranavkm mentioned this issue Apr 9, 2020
Merged
@javiercn javiercn added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 9, 2020
@wtgodbe
Copy link
Member

wtgodbe commented Apr 9, 2020

Should do this in 3.1 & master

@pranavkm
Copy link
Contributor Author

pranavkm commented Apr 9, 2020

master -> #20691
3.1 -> #20711

wtgodbe pushed a commit that referenced this issue Apr 10, 2020
@pranavkm
Turn off SDL validation (#20691)
9cab3e2 
Based on the discussion here: dotnet/arcade#5219
Re-enabling tracked by #20690
@dougbu
Copy link
Member

dougbu commented Oct 12, 2020

This was fixed a while ago. Then we migrated to a separate pipeline for the checks.

@dougbu dougbu closed this as completed Oct 12, 2020
@dougbu dougbu added the Done This issue has been fixed label Oct 12, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pranavkm @dougbu @javiercn @wtgodbe