-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Enable source-index for the repo #4790
Conversation
@@ -122,7 +122,7 @@ extends: | |||
enablePublishBuildAssets: true | |||
enableTelemetry: true | |||
enableSourceBuild: true | |||
enableSourceIndex: false | |||
enableSourceIndex: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need any conditions? Like just on windows, or just on official builds, just on main
, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question!
- This file is for the internal pipeline. The public one is
enableSourceIndex: false - This pipeline runs only the Windows build right now. There is a linux build in this same file conditioned on
_RunAsPublic
, which should be defaulting tofalse
for internal builds -aspire/eng/pipelines/common-variables.yml
Lines 13 to 15 in eb0bd80
- ${{ if notin(variables['Build.Reason'], 'PullRequest') }}: - name: _RunAsPublic value: False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RussKie why is there a linux job conditioned on _RunAsPublic
in
aspire/eng/pipelines/azure-pipelines.yml
Lines 165 to 193 in eb0bd80
- ${{ if eq(variables._RunAsPublic, True) }}: | |
- job: Linux | |
# timeout accounts for wait times for helix agents up to 30mins | |
timeoutInMinutes: 90 | |
pool: | |
name: NetCore1ESPool-Internal | |
image: 1es-mariner-2 | |
os: linux | |
variables: | |
- name: _buildScript | |
value: $(Build.SourcesDirectory)/build.sh --ci | |
preSteps: | |
- checkout: self | |
fetchDepth: 1 | |
clean: true | |
steps: | |
- template: /eng/pipelines/templates/BuildAndTest.yml | |
parameters: | |
dotnetScript: $(Build.SourcesDirectory)/dotnet.sh | |
buildScript: $(_buildScript) | |
buildConfig: $(_BuildConfig) | |
repoArtifactsPath: $(Build.Arcade.ArtifactsPath) | |
repoLogPath: $(Build.Arcade.LogsPath) | |
repoTestResultsPath: $(Build.Arcade.TestResultsPath) | |
isWindows: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ubuntu leg is only run on the public CI. I'm a little vague as to why it's not run on the internal CI (been many months since I asked that question) - I think it was something to do with lack of docker support...
Things may have changed since, so it's possible this condition can be removed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so no change needed in this PR.
This is to get enrolled into indexing for
https://source.dot.net
.