Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Enable source-index for the repo #4790

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

radical
Copy link
Member

@radical radical commented Jul 3, 2024

This is to get enrolled into indexing for https://source.dot.net.

@@ -122,7 +122,7 @@ extends:
enablePublishBuildAssets: true
enableTelemetry: true
enableSourceBuild: true
enableSourceIndex: false
enableSourceIndex: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need any conditions? Like just on windows, or just on official builds, just on main, etc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question!

  1. This file is for the internal pipeline. The public one is
    enableSourceIndex: false
  2. This pipeline runs only the Windows build right now. There is a linux build in this same file conditioned on _RunAsPublic, which should be defaulting to false for internal builds -
    - ${{ if notin(variables['Build.Reason'], 'PullRequest') }}:
    - name: _RunAsPublic
    value: False

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RussKie why is there a linux job conditioned on _RunAsPublic in

- ${{ if eq(variables._RunAsPublic, True) }}:
- job: Linux
# timeout accounts for wait times for helix agents up to 30mins
timeoutInMinutes: 90
pool:
name: NetCore1ESPool-Internal
image: 1es-mariner-2
os: linux
variables:
- name: _buildScript
value: $(Build.SourcesDirectory)/build.sh --ci
preSteps:
- checkout: self
fetchDepth: 1
clean: true
steps:
- template: /eng/pipelines/templates/BuildAndTest.yml
parameters:
dotnetScript: $(Build.SourcesDirectory)/dotnet.sh
buildScript: $(_buildScript)
buildConfig: $(_BuildConfig)
repoArtifactsPath: $(Build.Arcade.ArtifactsPath)
repoLogPath: $(Build.Arcade.LogsPath)
repoTestResultsPath: $(Build.Arcade.TestResultsPath)
isWindows: false
? When is that run?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ubuntu leg is only run on the public CI. I'm a little vague as to why it's not run on the internal CI (been many months since I asked that question) - I think it was something to do with lack of docker support...
Things may have changed since, so it's possible this condition can be removed now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so no change needed in this PR.

@radical radical enabled auto-merge (squash) July 4, 2024 01:33
@radical radical merged commit 670cb3d into dotnet:main Jul 4, 2024
9 checks passed
@radical radical deleted the ankj/source-indexer branch July 4, 2024 02:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants