Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Enable source-index for the repo #4790

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[ci] Enable source-index for the repo #4790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ extends:
enablePublishBuildAssets: true
enableTelemetry: true
enableSourceBuild: true
enableSourceIndex: false
enableSourceIndex: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need any conditions? Like just on windows, or just on official builds, just on main, etc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question!

  1. This file is for the internal pipeline. The public one is

    aspire/eng/pipelines/azure-pipelines-public.yml

    Line 92 in eb0bd80

    enableSourceIndex: false
  2. This pipeline runs only the Windows build right now. There is a linux build in this same file conditioned on _RunAsPublic, which should be defaulting to false for internal builds -

    aspire/eng/pipelines/common-variables.yml

    Lines 13 to 15 in eb0bd80

    - ${{ if notin(variables['Build.Reason'], 'PullRequest') }}:
    - name: _RunAsPublic
    value: False

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RussKie why is there a linux job conditioned on _RunAsPublic in

aspire/eng/pipelines/azure-pipelines.yml

Lines 165 to 193 in eb0bd80

- ${{ if eq(variables._RunAsPublic, True) }}:
- job: Linux
# timeout accounts for wait times for helix agents up to 30mins
timeoutInMinutes: 90
pool:
name: NetCore1ESPool-Internal
image: 1es-mariner-2
os: linux
variables:
- name: _buildScript
value: $(Build.SourcesDirectory)/build.sh --ci
preSteps:
- checkout: self
fetchDepth: 1
clean: true
steps:
- template: /eng/pipelines/templates/BuildAndTest.yml
parameters:
dotnetScript: $(Build.SourcesDirectory)/dotnet.sh
buildScript: $(_buildScript)
buildConfig: $(_BuildConfig)
repoArtifactsPath: $(Build.Arcade.ArtifactsPath)
repoLogPath: $(Build.Arcade.LogsPath)
repoTestResultsPath: $(Build.Arcade.TestResultsPath)
isWindows: false
? When is that run?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ubuntu leg is only run on the public CI. I'm a little vague as to why it's not run on the internal CI (been many months since I asked that question) - I think it was something to do with lack of docker support...
Things may have changed since, so it's possible this condition can be removed now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so no change needed in this PR.

publishAssetsImmediately: true
# Publish build logs
enablePublishBuildArtifacts: true
Expand Down
Loading