Parse cookies on redirect (legacy AndroidClientHandler) #7373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
grendello
approved these changes
Sep 14, 2022
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 16, 2022
* main: [docs] Document how to debug JNI Object Reference crashes (dotnet#7362) [Mono.Android] Parse cookies on redirect in AndroidClientHandler (dotnet#7373) Bump to xamarin/Java.Interop/main@fcc33ce2 (dotnet#7380) Bump to dotnet/installer@11f6b8f 7.0.100-rc.2.22459.2 (dotnet#7367) LEGO: Merge pull request 7385 Bump to xamarin/monodroid@135be73 (dotnet#7384) Bump to xamarin/xamarin-android-tools/main@0be567a9 (dotnet#7383) Bump to Tessil/robin-map@784245b4 [v1.0.1] (dotnet#7382) Bump to mono/mono@a96bde97 (dotnet#7372) [ci] Fix test categories for emu smoke tests (dotnet#7374) Bump to xamarin/monodroid@43583d02 (dotnet#7370)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
AllowAutoRedirectfeature ofAndroidClientHandlerto automatically follow 3xx redirects, the cookies that are returned together with the redirection are not processed. If the redirection target requires the cookies returned by the first request, the call will fail.With this change the cookies are always processes before the redirection takes place. Fixes #3954.
Please note that this change was already merged for
AndroidMessageHandler(see #6987), but not for the legacyAndroidClientHandler.