Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse cookies on redirect #6987

Merged
merged 1 commit into from
May 6, 2022

Conversation

dominik-weber
Copy link
Contributor

When using the AllowAutoRedirect feature of AndroidMessageHandler to automatically follow 3xx redirects, the cookies that are returned together with the redirection are not processed. If the redirection target requires the cookies returned by the first request, the call will fail.

This change fixes this behavior and always processes the cookies before the redirection takes place. Fixes #3954.

@grendello
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@grendello grendello merged commit efb693f into dotnet:main May 6, 2022
@dominik-weber dominik-weber deleted the dweber-fix-cookie-redirect branch May 6, 2022 10:03
jonathanpeppers pushed a commit that referenced this pull request May 6, 2022
Fixes: #3954

When using the `AllowAutoRedirect` feature of `AndroidMessageHandler` to automatically follow 3xx redirects, 
the cookies that are returned together with the redirection are not processed. If the redirection target requires 
the cookies returned by the first request, the call will fail.

This change fixes this behavior and always processes the cookies before the redirection takes place.
@jonathanpeppers
Copy link
Member

@dominik-weber I backported this to our .NET 6 release branch. Unless something unexpected happens, it should be in the final .NET 6 Android workload when it ships.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AndroidClientHandler doesn't forward cookies on redirect
3 participants