-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add netcoreapp3.0 global tool #315
Closed
Closed
Changes from 10 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
36cdadc
add netcoreapp3.0 global tool
ctaggart 0bc68a3
--force
ctaggart 74f520c
switch to preview4
ctaggart d332459
3.0.100-preview4-011223
ctaggart 5186d01
getVersion from 3.0
ctaggart 3563f98
try bumping ProtectedData to 4.5.0
ctaggart 29015e8
try CopyLocalLockFileAssemblies
ctaggart ad04550
just dotnet publish there
ctaggart 1050fcf
use 3.0.100-preview4-011223
ctaggart 60bc911
remove setting in pipelines
ctaggart 08264a1
upgrade System.Text.Encoding.CodePages to 4.5.1
ctaggart fb2a117
mv global.json back to src
ctaggart 612409a
npm needs to run same dotnet
ctaggart 157f09c
remove CodePages change
ctaggart 3937932
debug print dotnet --info
ctaggart bed9b9a
remove dotnet --info
ctaggart 6a68449
dotnet publish
ctaggart ffeac06
add BuildConfiguration
ctaggart 5f85295
in src already
ctaggart 4222f4d
mkdir bin/js
ctaggart 3cf40bb
Revert "mkdir bin/js"
ctaggart 6d926fd
mkdir -p bin/js
ctaggart 4540fe6
pack to bin
ctaggart e3c1fc4
CopyLocalLockFileAssemblies not needed
ctaggart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"sdk": { | ||
"version": "2.1.500" | ||
"version": "3.0.100-preview4-011223" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,14 +4,12 @@ | |
<ToolCommandName>nbgv</ToolCommandName> | ||
<PackAsTool>True</PackAsTool> | ||
<OutputType>Exe</OutputType> | ||
<TargetFramework>netcoreapp2.1</TargetFramework> | ||
<TargetFrameworks>netcoreapp2.1;netcoreapp3.0</TargetFrameworks> | ||
<RootNamespace>Nerdbank.GitVersioning.Tool</RootNamespace> | ||
<Description>A .NET Core Tool that can install, read and set version information based on git history, using Nerdbank.GitVersioning.</Description> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="NuGet.PackageManagement" Version="4.9.3" NoWarn="NU1701" /> | ||
<PackageReference Include="NuGet.Resolver" Version="4.9.3" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These were only used by |
||
<PackageReference Include="System.CommandLine" Version="0.1.0-preview2-180503-2" /> | ||
<PackageReference Include="Nerdbank.GitVersioning.LKG" Version="1.6.20-beta-gfea83a8c9e" PrivateAssets="all" /> | ||
<PackageReference Include="System.Diagnostics.Tools" Version="4.3.0" /> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This combined with TargetFrameworks does not work. It is easier to just
dotnet publish
.