add netcoreapp3.0 global tool #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what this error is from:
I know that switching from TargetFramework to TargetFrameworks adds an additional folder. May be something in the gulpfile needs updating. |
ctaggart
commented
Apr 22, 2019
| @@ -1,8 +1,6 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | |||
| <BaseIntermediateOutputPath>$(MSBuildThisFileDirectory)..\obj\$(MSBuildProjectName)\</BaseIntermediateOutputPath> | |||
| <OutputPath>$(MSBuildThisFileDirectory)..\bin\$(MSBuildProjectName)\$(Configuration)\</OutputPath> | |||
There was a problem hiding this comment.
This combined with TargetFrameworks does not work. It is easier to just dotnet publish.
ctaggart
commented
Apr 22, 2019
| <RootNamespace>Nerdbank.GitVersioning.Tool</RootNamespace> | ||
| <Description>A .NET Core Tool that can install, read and set version information based on git history, using Nerdbank.GitVersioning.</Description> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="NuGet.PackageManagement" Version="4.9.3" NoWarn="NU1701" /> | ||
| <PackageReference Include="NuGet.Resolver" Version="4.9.3" /> |
There was a problem hiding this comment.
These were only used by GetLatestPackageVersionAsync. They are netframework only and cause a bunch of dependency problems. Hopefully there is an easier way with NuGet 5.0.
This reverts commit 4222f4d.
Closed
AArnott
added a commit
that referenced
this pull request
Dec 8, 2024
Use `-LiteralPath` instead of `-Path` in ps1 scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #279 from @onovotny, but uses latest preview 3 and sets the global.json just on the Azure Pipelines build.