Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve extension removal readability #66

Merged
merged 1 commit into from
Sep 27, 2023
Merged

chore: improve extension removal readability #66

merged 1 commit into from
Sep 27, 2023

Conversation

velramiir
Copy link
Contributor

@velramiir velramiir commented Sep 27, 2023 •
edited
Loading

Ticket 🎫

This closes #65.

Description 📖

This simply removes the double assignment syntax, but does not change any functionality.

Checklist ✅

  • My changes generate no new warnings
  • Made corresponding changes to the documentation if applicable
  • Commented my code, particularly in hard-to-understand areas if applicable
  • Performed a self-review of my own changes

velramiir
velramiir commented Sep 27, 2023
View reviewed changes
Copy link
Contributor Author

@velramiir velramiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github actions didn't run

@velramiir velramiir force-pushed the chore/improve-extension-removal-readability branch from 6f264f4 to fe5e146 Compare September 27, 2023 14:06
@velramiir velramiir force-pushed the chore/improve-extension-removal-readability branch from fe5e146 to 886feac Compare September 27, 2023 14:14
@dotbase-bot dotbase-bot self-assigned this Sep 27, 2023
@dotbase-bot dotbase-bot requested a review from a team September 27, 2023 14:15
@dotbase-bot dotbase-bot added this to the next milestone Sep 27, 2023
@velramiir velramiir merged commit 58c54ff into main Sep 27, 2023
@velramiir velramiir deleted the chore/improve-extension-removal-readability branch September 27, 2023 14:20
This was referenced Sep 27, 2023
Closed
Merged
dotbase-bot added a commit that referenced this pull request Sep 27, 2023
@dotbase-bot
chore(release): v4.0.1
5a86f87 
### 🧹 Chore

* extract changelog config to .github repo ([e80d59c](e80d59c))
* extract pre-release to new action ([f46105d](f46105d))
* improve function clarity ([#66](#66)) ([58c54ff](58c54ff)), closes [#65](#65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreakreichgauer andreakreichgauer andreakreichgauer approved these changes

Assignees

@dotbase-bot dotbase-bot

Labels
None yet
Projects
None yet
Milestone
v4.0.1
Development

Successfully merging this pull request may close these issues.

Make extension removal easier to understand
3 participants
@velramiir @andreakreichgauer @dotbase-bot