Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make extension removal easier to understand #65

Closed
1 task done
velramiir opened this issue Sep 27, 2023 · 0 comments · Fixed by #66
Closed
1 task done

Make extension removal easier to understand #65

velramiir opened this issue Sep 27, 2023 · 0 comments · Fixed by #66

Comments

@velramiir
Copy link
Contributor

velramiir commented Sep 27, 2023 •
edited
Loading

🧽 Maintenance Description

We want to refactor the dummy extension removal because the double assignment is hard to read and understand at a glance.

r.item.extension = r.item.modifierExtension = undefined

✔ Acceptance Criteria

  • The double assignment is removed.
@velramiir velramiir mentioned this issue Sep 27, 2023
Merged
4 tasks
velramiir added a commit that referenced this issue Sep 27, 2023
@velramiir
chore: improve function clarity (#66)
58c54ff 
Ticket 🎫
This closes #65.

Description 📖
This simply removes the double assignment syntax, but does not change any functionality.
This was referenced Sep 27, 2023
Closed
Merged
dotbase-bot added a commit that referenced this issue Sep 27, 2023
@dotbase-bot
chore(release): v4.0.1
5a86f87 
### 🧹 Chore

* extract changelog config to .github repo ([e80d59c](e80d59c))
* extract pre-release to new action ([f46105d](f46105d))
* improve function clarity ([#66](#66)) ([58c54ff](58c54ff)), closes [#65](#65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: improve extension removal readability dot-base/icd-10-api
1 participant
@velramiir