Fix to invalidate the second redirect URI when the first URI is the native URI #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 29, 2017
| @@ -75,4 +75,11 @@ | |||
| expect(error).to eq('must be an HTTPS/SSL URI.') | |||
| end | |||
| end | |||
|
|
|||
| context 'multiple redirect uri' do | |||
| it 'invalidates the second uri when the first uri is native uri' do | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -75,4 +75,11 @@ | |||
| expect(error).to eq('must be an HTTPS/SSL URI.') | |||
| end | |||
| end | |||
|
|
|||
| context 'multiple redirect uri' do | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
eitoball
force-pushed
the
fix-when-native-redirect-uri-first-in-multiple-redirect-uri
branch
from
b82555e to
67c9520
Compare
|
Hi @eitoball. Yep, it's a nice point! Could you please resolve the conflicts, add an entry to NEWS.md file and squash commits to a single one? Thank you! |
eitoball
force-pushed
the
fix-when-native-redirect-uri-first-in-multiple-redirect-uri
branch
from
67c9520 to
da1116f
Compare
|
All Done. Thank you for checking in. |
This was referenced Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix to invalidates the second (or further) redirect URI when multiple redirect URIs are entered and the first URI is native URI like
urn:ietf:wg:oauth:2.0:oob.