-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify how to add local redirect URIs #1004
Clarify how to add local redirect URIs #1004
Conversation
Hi @jfly . What confusing you find in phrase "local tests"? I think it is clearly explain the purpose of native redirect uris. What do you think? |
CC-ing @Luis-J-Ianez, who originally told me he found the message confusing. He can probably give more insight into this than I can. If I were going to guess, I think the word "tests" is confusing because it makes a programmer think of test scripts, not development on localhost. |
Well, it's difficult to reproduce what my mind thought first when I read "Use blablabla for local tests". As now I understand the process, I can't reproduce the mistake, so to speak. But I remember that at first I thought the "blablabla" was a kind of alias for "localhost". In my view the new wording is more helpful. |
So @jfly @Luis-J-Ianez maybe we can extend this message by adding something like "for development purposes" in order to improve understanding of the help message? What do you think? Also can you please add a changelog entry to NEWS.md with descriptive comment of the changes and rebase to quash commits? Thanks for yo patience and work! |
50cc79f
to
22bad61
Compare
22bad61
to
24829fe
Compare
Done and done! |
Great, thanks @jfly! |
Hey, this message seems no longer accurate. As far as I can see, this behaviour relayed on a bug fixed in #976, namely: if you added |
One of our users was confused by the wording of this message and suggested this alternative wording, which I agree is superior.