-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support localization (#309) #861
base: dev
Are you sure you want to change the base?
Conversation
Have you tested it? Because I don't think our font has CJK glyphs. |
I'm temporarily using the default fonts that come with Windows. I plan to write an additional Python script to bake the fonts later. you can check the preview video here: #862 |
Why additional python scripts tho? I think you can just use |
The main reason is that I don’t want to upload multiple font blob files, for example Source Han Sans, which, if bundled with Japanese, Korean, and Chinese characters, would total about 20MB. I aim to pre-bake the assets to include only the characters that are actually used. |
This sounds like it needs to be part of the build system? Though I guess we'd only rerun when someone sees missing characters |
The code is expected to function without any significant issues. If you prefer to load the translation file immediately rather than relying on lazy loading, you can use a empty esp to assist SKSE load all assets at game startup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- (CN)
- "shaders"->着色器
- "File Watcher"->文件监控
- "deadzone"->死区
- Is the Japanese translation verified by any actual Japanese speaker?
Fixed txt was treated as binary. This means that the project must use the git version after this commit |
Lokalise is free for open source projects. As are other platforms. It's just a matter of doodlum choosing and setting it up. |
Preview.mp4 |
I use it in another open source project. You just set a ci to pull the latest translations. No need for PRs. |
How can you achieve this? The action forces me to create a PR: https://github.com/lokalise/lokalise-pull-action/blob/b7587f118420378e8fd825a04ac27a70bf2778f0/action.yml#L123-L134 |
@doodlum @alandtse @Pentalimbed I think the workflow is now stable and ready for review. Artifact: Release (Support Spanish & Chinese only) |
Can you provide a link to the lokalise project so we can join. We'll need at least one of us to be an admin of the project before we pull the PR. |
This requires your team to handle the configuration. My Lokalise account is currently in a free trial state and will expire soon. It's just for demonstration purposes. The configuration is very simple:
|
PR Summary: