Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement implicit commits and fix import behavior #8767

Merged
merged 19 commits into from
Jan 22, 2025
Prev Previous commit
Next Next commit
commit dropped tables
James Cor committed Jan 18, 2025
commit ba5bc63410f25804164e80be0f3ac394ac542210
1 change: 1 addition & 0 deletions go/libraries/doltcore/mvdata/engine_table_writer.go
Original file line number Diff line number Diff line change
@@ -231,6 +231,7 @@ func (s *SqlEngineTableWriter) WriteRows(ctx context.Context, inputChannel chan
// quitting import that created table, should drop table
if s.importOption == CreateOp {
s.se.Query(s.sqlCtx, fmt.Sprintf("DROP TABLE IF EXISTS `%s`", s.tableName))
s.se.Query(s.sqlCtx, "COMMIT")
}
return err
}