implement implicit commits and fix import behavior #8767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 17, 2025 11:27
added 4 commits
January 17, 2025 16:13
added 3 commits
January 21, 2025 00:36
zachmu
approved these changes
Jan 21, 2025
| line := 1 | ||
| // If there were create table statements, they are automatically committed, so we need to start a new transaction | ||
| if s.importOption == CreateOp { | ||
| _, _, _, err = s.se.Query(s.sqlCtx, "START TRANSACTION") |
There was a problem hiding this comment.
Always drain the row iter for these things, we often don't throw any error until iteration or even Close()
| // quitting import that created table, should drop table | ||
| if s.importOption == CreateOp { | ||
| var err error | ||
| _, _, _, err = s.se.Query(s.sqlCtx, fmt.Sprintf("DROP TABLE IF EXISTS `%s`", s.tableName)) |
added 3 commits
January 21, 2025 16:32
|
@coffeegoddd DOLT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the implicit commit logic introduced in this PR dolthub/go-mysql-server#2818
On error,
dolt table import -cdoes not create the table, and we did that by simply rolling back the existing transaction.Since DDL statements now implcitly
COMMIT, we need to start a new transaction, and possibly drop any tables created.fixes #7485
maybe fixes: #8716