Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scanner more safe whitespace skip #8499

Merged
merged 1 commit into from
Oct 30, 2024
Merged

scanner more safe whitespace skip #8499

merged 1 commit into from
Oct 30, 2024

Conversation

max-hoffman
Copy link
Contributor

No description provided.

@max-hoffman max-hoffman force-pushed the max/scan-skip-delimiter-whitespace branch from 772a397 to 9dbbc70 Compare October 28, 2024 15:59
@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9dbbc70 ok 5937457
version total_tests
9dbbc70 5937457
correctness_percentage
100.0

jycor
jycor approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@max-hoffman max-hoffman merged commit 2fe3344 into main Oct 30, 2024
21 of 22 checks passed
@max-hoffman max-hoffman deleted the max/scan-skip-delimiter-whitespace branch October 30, 2024 20:54
@BrewTestBot BrewTestBot mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-hoffman @coffeegoddd @jycor