Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
fixes: Crash when refreshing statistics after a PK column change dolthub/dolt#8504
Use schema hash to detect when database statistics might be incompatible. Drops all statistics for schema update. This could be improved to a subset of statistics if we wanted in the future.
@@server_id
to uint32 value when it gets loaded as a string from config.jsonAlso update README to reflect the bazel 6.3.0 version
kill query <pid>
go-mysql-server
resolveDescribeQuery
ruleThis rule just recurses into the analyzer, so we should just do it right at the beginning, so we should do it right away and avoid calling all other rules.
This would be better/cleaner in the planbuilder, but we would need to tell the analyzer to not analyze this node or skip it somehow.
It's possible to move this logic into
analyzeWithSelector
.It might be more difficult to move this above
Analyze
, as we'd have to put this logic in a variety of places.GMS server handler is supposed to cancel running queries if the connection which issued them goes away. It does this by checking the connection state out-of-band anytime the query is running and canceling theh query if the connection goes away. The connection checking code is platform-specific and currently only works on Linux.
In commit 538696b2c943ac7f3cacf1b67a3a5ff40ae64a00 I introduced a bug where the connection checking code tries to inspect the socket state of an already closed file descriptor. This change fixes the behavior so that the file descriptor is left open until the necessary socket state is extracted.
wrapTriggerRollback
logicThis PR removes the
plan.TriggerRollback
andplan.NoopTriggerRollback
node and applies thetriggerRollbackIter
directly.When there are multiple nested triggers (aka triggers that call other triggers), we used to have multiple nested trigger rollbacks with different savepoints. It turns out that was unnecessary and a single savepoint at the top of the iter tree is enough; when there's an error, it propagates back to the top, rollingback all changes.
Tests here: add bats test for
kill query <pid>
dolthub/dolt#8493Distinct
nodes belowSort
nodesThis PR optimized queries like:
i
, it is much more efficient to eliminate duplicates first, then sort the results.There are somewhat unrelated optimizations left as TODOs.
Optimize query: excessive memory usage during
SELECT DISTINCT
query dolthub/dolt#8488vitess
…d, which doesn't work with custom formatters)
This PR adds syntax support for quoted character set values.
fix: quoted character set value is not supported dolthub/dolt#8455
Closed Issues