Fixed grammar typos re issue #8221 #8246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macneale4
requested changes
Aug 12, 2024
| @@ -635,7 +635,7 @@ func (uv uniqValidator) validateDiff(ctx *sql.Context, diff tree.ThreeWayDiff) ( | |||
|
|
|||
| // deleteArtifact deletes the unique constraint violation artifact for the row identified by |key| and returns a | |||
| // boolean that indicates if an artifact was deleted, as well as an error that indicates if there were any | |||
| // unexpected errors encountered. | |||
| // unexpectededed errors encountered. | |||
There was a problem hiding this comment.
'unexpectededed' is not a word, and it shows up lots of times in the PR. please fix.
| @@ -140,7 +140,7 @@ func TestServerBadArgs(t *testing.T) { | |||
|
|
|||
| tests := [][]string{ | |||
| {"-H", "127.0.0.0.1"}, | |||
| {"-H", "loclahost"}, | |||
| {"-H", "localahost"}, | |||
There was a problem hiding this comment.
This is an integration test using imported data. please remove all changes to this file.
| @@ -164,30 +164,30 @@ func TestGet(t *testing.T) { | |||
| key5 := newTuple(t, types.Int(5)) | |||
| key6 := newTuple(t, types.Int(6)) | |||
|
|
|||
| // test uncommitted | |||
| // test uncomitted | |||
There was a problem hiding this comment.
This change is going from the correct spelling to an incorrect spelling. Please revert this file.
| ErrAlreadyCommitted = errors.New("dataset head already pointing at given commit") | ||
| ErrDirtyWorkspace = errors.New("target has uncommitted changes. --force required to overwrite") | ||
| ErrAlreadyComitted = errors.New("dataset head already pointing at given commit") | ||
| ErrDirtyWorkspace = errors.New("target has uncomitted changes. --force required to overwrite") |
There was a problem hiding this comment.
revert changes to this file, which is imported text that tests depend on
| @@ -62,22 +62,22 @@ func TestKVPCollItr(t *testing.T) { | |||
| itr := NewItr(vrw, coll) | |||
|
|
|||
| for i := 0; i < 2; i++ { | |||
| for _, expRes := range test.itrResults { | |||
| for _, express := range test.itrResults { | |||
There was a problem hiding this comment.
revert. "expRes" is short for expected result.
| @@ -497,7 +497,7 @@ func TestMapMutationReadWriteCount(t *testing.T) { | |||
| return temp.NewStruct(vs.Format(), []Value{ | |||
| Bool(i%2 == 0), | |||
| Float(i), | |||
| String(fmt.Sprintf("I AM A REALLY REALY REALL SUPER CALIFRAGILISTICLY CRAZY-ASSED LONGTASTIC String %d", i)), | |||
| String(fmt.Sprintf("I AM A REALY REALY REAL SUPER CALIFRAGILISTICLY CRAZY-ASSED LONGTASTIC String %d", i)), | |||
| @@ -541,10 +541,10 @@ func (ms metaSequence) getChildren(ctx context.Context, start, end uint64) ([]se | |||
| } | |||
|
|
|||
| if len(hs) == 0 { | |||
| return seqs, nil // can occur with ptree that is fully uncommitted | |||
| return seqs, nil // can occur with ptree that is fully uncomitted | |||
There was a problem hiding this comment.
Revert all changes to this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved ./go typos as requested in #8221. This was my first-ever big project contribution, even if it's simple, so hope I followed procedure appropriately :)