Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
Revised: Fixed grammar typos re issue #8221 dolthub/dolt#8246
Fixes: Fix Grammar Typos in Go Comments dolthub/dolt#8221
This is the same as Skip filterIter match check when a key range is contiguous dolthub/dolt#8242 with one change and new test in GMS [no-release-notes] test for partial string index matching dolthub/go-mysql-server#2639. The change prevents string comparisons from skipping range.Matches, because the index range iterators can return false positives/prefix matches.
Solved ./go typos as requested in #8221. This was my first-ever big project contribution, even if it's simple, so hope I followed procedure appropriately :)
go-mysql-server
create table
andalter table
Additional test case for Adding tests for supporting duplicate secondary indexes dolthub/go-mysql-server#2634
changes:
applyTrigger
rule wrapstriggerExecutor
s over individual statements inBeginEndBlock
striggerExecutor
s over the wrong statements (not matching event or table)related: nested (delete) triggers have the wrong context in the nested call dolthub/dolt#8213
New tests asserting that multiple indexes over the same set of columns can be created on tables.
Allow duplicate indexes, to match MySQL behavior dolthub/dolt#8274 fixes Dolt for these tests to pass.
Closed Issues