Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameINI: Use Safe Texture Cache for Cabela's Dangerous Hunts 2011 #13202

Conversation

Pokechu22
Copy link
Contributor

This fixes text on the menu and in-game.

Previously tested by @JMC47 (though I'm not sure if it was the regular version or the special edition that was tested; the main difference is that the special edition has an option for a questionable cel-shading effect).

There's still a possibility of some audio issues in this game, but I don't own it (so I couldn't confirm if it was an HLE vs LLE difference) and couldn't find any videos of it on real hardware that had stereo audio.

Comment on lines 3 to 10
[Core]
# Values set here will override the main Dolphin settings.

[OnFrame]
# Add memory patches to be applied every frame here.

[ActionReplay]
# Add action replay cheats here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, I recall discussing this when we flipped the EFB default that there's no point to include these sections if nothing is in them.
I don't particularly care if they stay though since other games do this too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, yeah, might as well not add them. It might be worth getting rid of them from everywhere (I removed the completely useless OnLoad sections in #13138).

@Pokechu22 Pokechu22 force-pushed the cabelas-dangerous-hunts-2011-safe-texture-cache branch from 4a37211 to 6462e79 Compare November 29, 2024 20:09
@dreamsyntax
Copy link
Member

dreamsyntax commented Nov 29, 2024

One more thing, was the behavior when "0" is used fixed in Dolphin? I recall setting texture cache to 0 led to weird bugs in Shadow the Hedgehog, which is why we used the middle option.

See #13141

@JosJuice
Copy link
Member

There hasn't been any fix to that as far as I know, but that's also an issue I've never heard of happening in any game other than Shadow the Hedgehog.

@Pokechu22
Copy link
Contributor Author

Hmm, a value of 0 should generally be more accurate. It sounds like for Shadow the Hedgehog some weird stuff is going with textures getting evicted from the texture cache (probably related to TMEM/the GameCube hardware texture cache, which Dolphin doesn't handle super well).

JMC did say medium does not work for this game, though.

@Pokechu22 Pokechu22 merged commit 3b34063 into dolphin-emu:master Nov 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants