Do not expose DefaultLifecycle from IContainer. #716 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead clients should set the default lifecycle on the container either before returning from ICanCreateContainer.CreateContainer or before the call to Configure.With. Original issue: ProCoSys#16
|
I'll have to look into it and consider the effect of this as it is a breaking change. For now I've marked it as a minor change - although it is an API change and should be part of a major release, this is probably not as severe |
|
Sounds reasonable. (The methods will be rewritten again if you want to take my yet-to-come Configuration pull request, I just think this is a valuable addition as is.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead clients should set the default lifecycle on the container either
before returning from ICanCreateContainer.CreateContainer or before the call to Configure.With.
Original issue: ProCoSys#16
Original commit: ProCoSys@7393a03