Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiscoverAndConfigure cannot be used when default convention is Singleton #16

Closed
bnordli opened this issue Mar 2, 2016 · 1 comment
Closed

DiscoverAndConfigure cannot be used when default convention is Singleton #16

bnordli opened this issue Mar 2, 2016 · 1 comment

Comments

@bnordli
Copy link

bnordli commented Mar 2, 2016

DiscoverAndConfigure uses a hard coded BindingLifecycle.Transient instead of reading from container.DefaultLifecycle, making it impossible to use another default convention.
@bnordli
Copy link
Author

bnordli commented Mar 2, 2016

In fact, IContainer does not need to expose DefaultLifecycleat all.

bnordli added a commit that referenced this issue Mar 2, 2016
@bnordli
Do not expose DefaultLifecycle from IContainer. #16
7393a03
@bnordli bnordli mentioned this issue Mar 2, 2016
Merged
@bnordli bnordli closed this as completed Mar 2, 2016
@bnordli bnordli mentioned this issue Jan 7, 2017
Open
bnordli added a commit to bnordli/Bifrost-statoil that referenced this issue Jan 7, 2017
@bnordli
Do not expose DefaultLifecycle from IContainer. dolittle#716
ceda934 
Instead clients should set the default lifecycle on the container either
before returning from ICanCreateContainer.CreateContainer or before the call to Configure.With.

Original issue: ProCoSys#16
@bnordli bnordli mentioned this issue Jan 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnordli