Configure should not care about default lifecycle #716
Comments
bnordli
added a commit
to bnordli/Bifrost-statoil
that referenced
this issue
Jan 7, 2017
Instead clients should set the default lifecycle on the container either before returning from ICanCreateContainer.CreateContainer or before the call to Configure.With. Original issue: ProCoSys#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See ProCoSys#16. Related to #686, but pulled out as a separate bug because of the somewhat breaking changes.
It started with a bug that
Configure.DiscoverAndConfigurewas hard coded to usingBindingLifecycle.Transient, but ended with the realization thatConfiguredoes not have to deal with a default lifecycle at all, becauseEither
.DiscoverAndConfigureis used, and then the container is created by anICanCreateContainer. This method can easily set the lifecycle on the container before returning, or.With(IContainer container ...)method is used, and then the lifecycle can be set before this method is called.In the end, the
Configureclass can be simplified a lot.The breaking changes are the removal of the
Containermethods with BindingLifecycle parameters, a compile time change. (If wanted, these can instead be kept and obsoleted, but I don't think that is needed.)The text was updated successfully, but these errors were encountered: