Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClientSettings refactoring #38

Closed
DashaBulanova opened this issue Oct 16, 2020 · 2 comments
Closed

HttpClientSettings refactoring #38

DashaBulanova opened this issue Oct 16, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
v2.0.0

Comments

@DashaBulanova
Copy link
Contributor

DashaBulanova commented Oct 16, 2020 •
edited
Loading

Problem description

The first problem is the name of HttpClientSettings does not reflect the core idea of the library. It would be better PollyDefaultSettings or something like this.

The second problem is according to framework design guidelines using constructors is not very usable in this type of object. It would be better to make public setters for all settings.
@Ceridan Ceridan added the enhancement New feature or request label Oct 16, 2020
@Ceridan
Copy link
Contributor

Ceridan commented Oct 16, 2020 •
edited
Loading

Yes, we could change the naming, but I prefer to avoid name PollyDefaultSettings. I understand that currently we are strongly bound to Polly, but in general case Polly is just an implementation details of our library. We able to replace Polly with something else and save our API for the end-user without changes.

@Ceridan Ceridan added this to the v2.0.0 milestone Oct 17, 2020
@Ceridan
Copy link
Contributor

Ceridan commented Nov 2, 2020

Closed by #43, #46, #47

Will be released in version v2.0.0.

See milestone v2.0.0

@Ceridan Ceridan closed this as completed Nov 2, 2020
@Ceridan Ceridan mentioned this issue Dec 5, 2020
Merged
Ceridan added a commit that referenced this issue Dec 5, 2020
@Ceridan
Merge pull request #60 from dodopizza/milestone/v2.0.0
810c8d1 
Milestone v2.0.0

Milestone include major changes including breaking changes.
Full list of changes:
- Fix namespace clash between Dodo.HttpClient and System.Net.Http.HttpClient (#32)
- Add OverallTimeoutPolicy (#13)
- AddDefaultPolicies is renamed to AddResiliencePolicies (#45)
- CircuitBreaker is host specific by default. Host agnostic version is removed (#44)
- HttpClientSettings is replaced with ResiliencePoliciesSettings (#38)
- Add support of Retry-After http header (#40)
- Refactor API for end-users (#51)
- Re-write README (#24)
- Add .NET 5 support (#53)
- Fix flaky test (#52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@Ceridan @DashaBulanova