Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Overall Timeout policy #13

Closed
DashaBulanova opened this issue Apr 10, 2020 · 3 comments
Closed

Add Overall Timeout policy #13

DashaBulanova opened this issue Apr 10, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone
v2.0.0

Comments

@DashaBulanova
Copy link
Contributor

Description
Library uses only timeout-per-try and all responsibility rests with the client.
But It'll be better to add an overall-timeout-policy to concentrate full responsibility in the library.

Suggested ordering of overall-timeout-policy at the below image:

image

All additional information see at:
https://github.com/App-vNext/Polly/wiki/Timeout
https://github.com/App-vNext/Polly/wiki/Polly-and-HttpClientFactory#use-case-applying-timeouts
@k-tomak k-tomak added the enhancement New feature or request label Apr 10, 2020
@NYMEZIDE
Copy link
Contributor

NYMEZIDE commented Oct 7, 2020

I'll take it when I'm done issue #14.
I read the theory. Everything seems to be clear.

@Ceridan
Copy link
Contributor

Ceridan commented Oct 8, 2020

The tricky part is this thing. The HttpClient has its own timeout also which could be considered as a kind of overall timeout too. We need to find a way how to make them work together correctly.

@NYMEZIDE NYMEZIDE mentioned this issue Oct 10, 2020
Merged
@Ceridan Ceridan added this to the v2.0.0 milestone Oct 17, 2020
@Ceridan
Copy link
Contributor

Ceridan commented Oct 18, 2020

Done. Thanks to @NYMEZIDE

Will be released in version v2.0.0.

See milestone v2.0.0

@Ceridan Ceridan closed this as completed Oct 18, 2020
@Ceridan Ceridan mentioned this issue Dec 5, 2020
Merged
Ceridan added a commit that referenced this issue Dec 5, 2020
@Ceridan
Merge pull request #60 from dodopizza/milestone/v2.0.0
810c8d1 
Milestone v2.0.0

Milestone include major changes including breaking changes.
Full list of changes:
- Fix namespace clash between Dodo.HttpClient and System.Net.Http.HttpClient (#32)
- Add OverallTimeoutPolicy (#13)
- AddDefaultPolicies is renamed to AddResiliencePolicies (#45)
- CircuitBreaker is host specific by default. Host agnostic version is removed (#44)
- HttpClientSettings is replaced with ResiliencePoliciesSettings (#38)
- Add support of Retry-After http header (#40)
- Refactor API for end-users (#51)
- Re-write README (#24)
- Add .NET 5 support (#53)
- Fix flaky test (#52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
4 participants
@Ceridan @DashaBulanova @NYMEZIDE @k-tomak