Make wavy underline markings smaller #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
bmesuere
requested changes
Sep 20, 2023
There was a problem hiding this comment.
I can live with using an image mask for this, but I don't think this is implemented in the most efficient way.
Right now, the style is added inline to each instance of the custom element (it is added to the template). I would expect it to be in a general css file, or in the static styles of the element.
|
The styling is also broken in combination with comments I knew about the inefficiency of inline style, but this problem has indeed become worse now that we use svg images |
chvp
approved these changes
Sep 21, 2023
bmesuere
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces wavy underline with custom svg styling. I copied the svg from codemirror.
The background image has to be defined within the theme as we cannot use css variables inside the image. I wrote a mixin to avoid a lot of duplicate sass.
The styles are also moved to static css classes, which should render more efficiently.
Chrome
Old
New
Firefox
Old
New
Closes #4943