Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using wavy text decoration for multiline annotations #4943

Closed
pdawyndt opened this issue Sep 5, 2023 · 1 comment · Fixed by #4989
Closed

Avoid using wavy text decoration for multiline annotations #4943

pdawyndt opened this issue Sep 5, 2023 · 1 comment · Fixed by #4989
Assignees
Labels
feature New feature or request

Comments

@pdawyndt
Copy link
Contributor

pdawyndt commented Sep 5, 2023

Multiline annotations from the linter use the wavy text decoration, which hampers readability of the code fragment. Might be better to use the same background-color annotations as with manual multiline annotations. Using wavy text decoration for inline annotations with background highlighting for multiline annotations also seems to mix better if both are combined in the same code fragment.

image

@pdawyndt pdawyndt added the feature New feature or request label Sep 5, 2023
@github-project-automation github-project-automation bot moved this to Unplanned in Roadmap Sep 5, 2023
@jorg-vr
Copy link
Contributor

jorg-vr commented Sep 12, 2023

I have seen this complaint before and I do agree that this kind of marking is to prominent and distracting

I do not think avoiding the marking only for multiline errors is the correct solution.
Depending on the judge and the code a warning code be created on every line, resulting in equally distracting markings.
I also think that warnings of the same type should always use the same styling, regardless of how many lines they span.

I am looking around what other sytems do, and their wavy underlines are always less prominent.
Eg outlook:
image
Eg code miror:
image

I wasn't able to find how outlook renders the wavy underline, but codemirror seems to use svg background images, which is something we might be able to pull of as well

This would also remove some cross browser differences

@jorg-vr jorg-vr self-assigned this Sep 20, 2023
@jorg-vr jorg-vr moved this from Unplanned to In Progress in Roadmap Sep 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants