Improve Comparison::CONTAINS: allow to use custom position for % and _ wildcard characters

[Fedik]

This pull prevent forced wrapping of the value in to %
and allow to use the custom position for % and _ wildcard characters in case Comparison::CONTAINS

Allow to build the contains expressions like:

Criteria::expr()->contains('myField', 'some string%');
Criteria::expr()->contains('myField', '%some string');
Criteria::expr()->contains('myField', '%10\%'); // search for 10% at end of the string
Criteria::expr()->contains('myField', 's_m_ string');

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3328

We use Jira to track the state of pull requests and the versions they got
included in.

[stof]

your implementation is wrong. % and _ chars need to be escaped all the time (actually, the list should be taken from https://github.com/doctrine/dbal/blob/7175964c30f4fd54c90f6f9c7c6f7bf49fc1c939/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php#L597). Otherwise, the behavior of contains() will not be consistent between the SQL matching and the in-memory matching.

[Fedik]

not very understand why wrong,
in original was just "%{$value}%", unescaped ... and I am a bit extend this 😄

And example: if I will search (escaped) s\_m\_ string then SQL search exactly for string s_m_ string, means will ignore the wildcard characters

or "original" also wrong?

[stof]

@Fedik the original is missing the escaping of $value before wrapping it in %

[Fedik]

but
if do like "\%{$value}\%" and value example will be some text,
then final SQL will be field LIKE \%some text\% ...
so SQL will search for exact %some text% instead of any_string some text any_string

that is why I am confused by your comment 😄

ah, I understand, sorry 😄

ok, but here is problem,
what if I want search 'string starts on TEXT'?
after this pull I can just do Criteria::expr()->contains('myField', 'TEXT%');
and if by your suggestion $value will be escaped then I cannot do this

[stof]

@Fedik I'm saying it should escape $value. You own proposal is escaping the extra placeholders added by Doctrine and leaves the value unescaped, so doing exactly the opposite

[Fedik]

@stof sorry, made long editing of previous comment 😉

[stof]

@Fedik your proposal of Criteria::expr()->contains('myField', 'TEXT%') does not respect the Criteria API if you expect it to search only at the beginning of values, and would require to make the API tied to SQL (which is the opposite of its goal) and totally weird (unless you require putting the % at the beginning and the end explicitly all the time, which is a BC break and still tied to SQL).

Your expectation is that some magic values turn contains() into a startsWith criteria. this does not make sense.

[Ocramius]

@Fedik what @stof is saying is that Doctrine\Common\Collections\ArrayCollection#matching($criteria) won't work like the Doctrine\ORM\PersistentCollection#matching($criteria) with these different contains() semantics.

[Fedik]

@Ocramius thanks, this part was confusing for me, I thought only about SQL part, I very bad in Doctrine architecture.

So this in Doctrine\Common\Collections\Expr\ClosureExpressionVisitor.php#walkComparison ?:

case Comparison::CONTAINS:
  return function ($object) use ($field, $value) {
    return false !== strpos(ClosureExpressionVisitor::getObjectFieldValue($object, $field), $value);
  };

Then have no idea how to do this 😄 ... hm, build some preg_macth...

Maybe some suggestion how to make this work? or really no way?

[Ocramius]

@Fedik preg_match could work here, yes.

[Fedik]

ok, so I made pull also for doctrine/collections#45