Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert temporarily ignored to file based triggerIfNotCalledFromWithinPackage #20

Closed
beberlei opened this issue Mar 11, 2021 · 0 comments · Fixed by #21
Closed

Convert temporarily ignored to file based triggerIfNotCalledFromWithinPackage #20

beberlei opened this issue Mar 11, 2021 · 0 comments · Fixed by #21
Assignees
@beberlei

Comments

@beberlei
Copy link
Member

We pass the package name, so we can use that for testing for vendor/{$packageName} in the caller. If that matches, the deprecation should be suppressed.

This would avoid having to first ignore then trigger a deprecation, which might look weird.

This will replace and remove #18 (proposed in #16)
@beberlei beberlei self-assigned this Mar 11, 2021
beberlei added a commit that referenced this issue Mar 11, 2021
@beberlei
[GH-20] triggerIfCalledFromOutside
992b668
@beberlei beberlei mentioned this issue Mar 11, 2021
Merged
beberlei added a commit that referenced this issue Mar 11, 2021
@beberlei
[GH-20] triggerIfCalledFromOutside
7028bea
beberlei added a commit that referenced this issue Mar 11, 2021
@beberlei
[GH-20] triggerIfCalledFromOutside
907ac04
beberlei added a commit that referenced this issue Mar 11, 2021
@beberlei
Merge pull request #21 from doctrine/GH-20-TriggerWhenNotFromPackage
db319bc 
[GH-20] triggerIfCalledFromOutside
beberlei added a commit that referenced this issue Mar 11, 2021
@beberlei
[GH-20] Bugfix: Do trigger when root package deprecation from /tests/
98cd98d
beberlei added a commit that referenced this issue Mar 13, 2021
@beberlei
[GH-20] Add tests for triggerIfCalledFromOutside
d3153a1
beberlei added a commit that referenced this issue Mar 13, 2021
@beberlei
[GH-20] Add tests for triggerIfCalledFromOutside
d4ad283
beberlei added a commit that referenced this issue Mar 13, 2021
@beberlei
Merge pull request #22 from doctrine/GH-20-TriggerWhenNotFromPackage
7a0388d 
[GH-20] Add tests for triggerIfCalledFromOutside
beberlei added a commit that referenced this issue Mar 13, 2021
@beberlei
[GH-20] Fix tests condition for detecting outside/inside code and imp…
6df3bae 
…rove tests.
@beberlei beberlei mentioned this issue Mar 13, 2021
Merged
beberlei added a commit that referenced this issue Mar 13, 2021
@beberlei
Merge pull request #23 from doctrine/GH-20-FixConditionForTestsFolder
d7eade7 
[GH-20] Fix tests condition for detecting outside/inside code and imp…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beberlei beberlei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-20] triggerIfCalledFromOutside doctrine/deprecations
1 participant
@beberlei