[GH-20] Add tests for triggerIfCalledFromOutside

composer.json

@@ -17,5 +17,11 @@
     },
     "autoload": {
         "psr-4": {"Doctrine\\Deprecations\\": "lib/Doctrine/Deprecations"}
+    },
+    "autoload-dev": {
+        "psr-4": {
+            "DeprecationTests\\": "tests/fixtures/src",
+            "Doctrine\\Foo\\": "tests/fixtures/vendor/doctrine/foo"
+        }
     }
 }

tests/Doctrine/Deprecations/DeprecationTest.php

@@ -184,4 +184,41 @@ public function testDeprecationWithIgnoredPackage(): void
         $this->assertEquals(1, Deprecation::getUniqueTriggeredDeprecationsCount());
         $this->assertEquals(['https://github.com/doctrine/orm/issue/1234' => 1], Deprecation::getTriggeredDeprecations());
     }
+
+    public function testDeprecationIfCalledFromOutside(): void
+    {
+        Deprecation::enableWithTriggerError();
+
+        try {
+            \DeprecationTests\Foo::triggerDependencyWithDeprecation();
+
+            $this->fail('Not expected to get here');
+        } catch (\Throwable $e) {
+            $this->assertEquals(
+                'Bar::oldFunc() is deprecated, use Bar::newFunc() instead. (Bar.php:14 called by Foo.php:12, https://github.com/doctrine/foo, package doctrine/foo)',
+                $e->getMessage()
+            );
+
+            $this->assertEquals(['https://github.com/doctrine/foo' => 1], Deprecation::getTriggeredDeprecations());
+        }
+    }
+
+    public function testDeprecationIfCalledFromOutsideNotTriggeringFromInside(): void
+    {
+        Deprecation::enableWithTriggerError();
+
+        \DeprecationTests\Foo::triggerDependencyWithDeprecationFromInside();
+
+        $this->assertEquals(0, Deprecation::getUniqueTriggeredDeprecationsCount());
+    }
+
+    public function testDeprecationIfCalledFromOutsideNotTriggeringFromInsideClass(): void
+    {
+        Deprecation::enableWithTriggerError();
+
+        $baz = new \Doctrine\Foo\Baz();
+        $baz->usingOldFunc();
+
+        $this->assertEquals(0, Deprecation::getUniqueTriggeredDeprecationsCount());
+    }
 }

tests/fixtures/src/Foo.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace DeprecationTests;
+
+use Doctrine\Foo\Bar;
+
+class Foo
+{
+    public function triggerDependencyWithDeprecation()
+    {
+        $bar = new Bar();
+        $bar->oldFunc();
+    }
+
+    public function triggerDependencyWithDeprecationFromInside()
+    {
+        $bar = new Bar();
+        $bar->newFunc();
+    }
+}

tests/fixtures/vendor/doctrine/foo/Bar.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace Doctrine\Foo;
+
+use Doctrine\Deprecations\Deprecation;
+
+class Bar
+{
+    public function oldFunc()
+    {
+        Deprecation::triggerIfCalledFromOutside(
+            'doctrine/foo',
+            'https://github.com/doctrine/foo',
+            'Bar::oldFunc() is deprecated, use Bar::newFunc() instead.'
+        );
+    }
+
+    public function newFunc()
+    {
+        $this->oldFunc();
+    }
+}

tests/fixtures/vendor/doctrine/foo/Baz.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Doctrine\Foo;
+
+class Baz
+{
+    public function usingOldFunc()
+    {
+        $bar = new Bar();
+        $bar->oldFunc();
+    }
+}