Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the ramsey/composer-install action to install dependencies #4463

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Use the ramsey/composer-install action to install dependencies #4463

merged 1 commit into from
Dec 13, 2020

Conversation

nicwortel
Copy link
Contributor

Follow-up of doctrine/.github#16.

@nicwortel nicwortel mentioned this pull request Dec 12, 2020
Merged
@nicwortel
Copy link
Contributor Author

nicwortel commented Dec 12, 2020 •
edited
Loading

This PR is currently not mergeable because this PR has required builds configured which reference matrix values which were changed.

fixed has become locked and low has become lowest, as these are the dependency-versions values expected by ramsey/composer-install.

Therefor:

  • PHPUnit with SQLite (7.3, fixed) has become PHPUnit with SQLite (7.3, locked)
  • PHPUnit with SQLite (7.4, fixed) has become PHPUnit with SQLite (7.4, locked)
  • PHPUnit with SQLite (8.0, fixed) has become PHPUnit with SQLite (8.0, locked)
  • PHPUnit with SQLite (low, 7.3) has become PHPUnit with SQLite (lowest, 7.3)

Someone with the proper (admin?) permissions needs to un-require these specific jobs (and probably require the new ones) so this PR can be merged.

This issue will again arise in follow-up PR #4464 because in that PR locked jobs become highest.

@nicwortel nicwortel marked this pull request as ready for review December 12, 2020 18:23
@greg0ire greg0ire requested a review from morozov December 12, 2020 19:41
@greg0ire greg0ire added the CI label Dec 12, 2020
@greg0ire greg0ire merged commit 4211e3c into doctrine:2.12.x Dec 13, 2020
@greg0ire
Copy link
Member

Thanks @nicwortel !

@nicwortel nicwortel deleted the ramsey-composer-install branch December 13, 2020 10:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@morozov morozov morozov approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicwortel @greg0ire @morozov