-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ramsey/composer-install action to install dependencies #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reusable action installs and caches Composer dependencies. The --no-interaction, --no-progress, and --ansi flags are added automatically. It can also handle installing highes (composer update) or lowest (composer update --prefer-lowest) versions of dependencies. See https://github.com/marketplace/actions/install-composer-dependencies.
greg0ire
requested review from
alcaeus,
beberlei,
lcobucci,
malarzm,
morozov,
Ocramius,
ostrolucky,
SenseException,
stof and
TomHAnderson
December 5, 2020 12:34
greg0ire
approved these changes
Dec 5, 2020
SenseException
approved these changes
Dec 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests of the action seem to cover the replaced steps.
alcaeus
approved these changes
Dec 7, 2020
beberlei
approved these changes
Dec 7, 2020
Thanks @nicwortel, I think you can go ahead! |
This was referenced Dec 10, 2020
greg0ire
pushed a commit
to doctrine/orm
that referenced
this pull request
Dec 10, 2020
This was referenced Dec 10, 2020
franmomu
added a commit
to franmomu/persistence
that referenced
this pull request
Dec 19, 2020
franmomu
added a commit
to franmomu/persistence
that referenced
this pull request
Dec 19, 2020
greg0ire
pushed a commit
to greg0ire/annotations
that referenced
this pull request
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating doctrine/data-fixtures from Travis CI to GitHub Actions (doctrine/data-fixtures#353), looking for an elegant way to add a job with the lowest dependency versions I came across the composer-install action made by @ramsey.
This action makes it easy to choose between installing locked versions (
composer install
), highest versions (composer update
), and lowest versions (composer update --prefer-lowest
). The--no-interaction
,--no-progress
, and--ansi
flags are automatically added to the command. It also handles caching of dependencies to improve build times.In other words, something like this:
can be rewritten to this:
I believe this greatly improves the readability and maintainability of GitHub Actions workflows in the Doctrine organization.
As suggested by @greg0ire I'm opening this PR to discuss the usage of this GitHub Action on an organization level.