Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use symfony/deprecation-contracts #691

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Use symfony/deprecation-contracts #691

merged 1 commit into from
Aug 9, 2021

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Aug 8, 2021

Following doctrine/DoctrineBundle@0a43514

This should also fix the build from #690

@franmomu franmomu requested a review from alcaeus August 8, 2021 19:23
alcaeus
alcaeus previously requested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree: since the bundle provides integration into Symfony, it should keep emitting deprecation notices for that framework.

@alcaeus alcaeus dismissed their stale review August 9, 2021 08:30

Symfony deprecations are fine 😊

alcaeus
alcaeus approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got confused with Doctrine deprecations. Thanks @franmomu!

@franmomu franmomu merged commit 3f6449e into doctrine:4.4.x Aug 9, 2021
@franmomu franmomu deleted the symfony_deprecations branch August 9, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malarzm malarzm malarzm approved these changes

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franmomu @alcaeus @malarzm