Basic implementation of psr6 compatibility pass #690
Conversation
|
Thanks @Ahummeling! In order to fix the build, can you please execute The failing test should be fixed if you rebase with |
| { | ||
| private const CACHE_SETTER_METHODS_PSR6_SUPPORT = [ | ||
| 'setMetadataCache' => true, | ||
| 'setMetadataCacheImpl' => true, |
There was a problem hiding this comment.
| 'setMetadataCacheImpl' => true, |
| 'doctrine/doctrine-bundle', | ||
| '2.4', |
There was a problem hiding this comment.
| 'doctrine/doctrine-bundle', | |
| '2.4', | |
| 'doctrine/mongodb-odm-bundle', | |
| '4.4', |
There was a problem hiding this comment.
Whoops, fixed that
|
just need to have a testcase added for the compiler pass now and this should be complete |
| $compatibilityLayerId = $definitionId . '.compatibility_layer'; | ||
| $container->setAlias($compatibilityLayerId, $aliasId); | ||
|
|
||
| $container->setDefinition($compatibilityLayerId, $compatibilityLayer); |
There was a problem hiding this comment.
Not sure about this, but if I had understood correctly, if $compatibilityLayer is not null, it is a definition implementing PSR-6 to replace the current definition, so should we replace the current alias with the compatibilityLayer one (flip arguments)?:
$container->setAlias($aliasId, $compatibilityLayerId);
franmomu
force-pushed
the
add-psr6-compatibility
branch
from
c439111
to
b53bf56
Compare
|
@Ahummeling I've rebased, tried to add tests for the compiler pass (based on the ORM) and fixed some psalm issues, finally I've flipped the alias arguments to make tests pass, but not sure if I was right about that last one 🤔 cc @alcaeus |
franmomu
force-pushed
the
add-psr6-compatibility
branch
from
9836db1
to
7b77663
Compare
IonBazan
force-pushed
the
add-psr6-compatibility
branch
from
052ff4d
to
9103365
Compare
|
I've rebased, resolved conflicts and added a dummy assertion to make PHPUnit report the coverage for that CompilerPass test. |
|
Not sure why doesn't infer correctly that class string type 😕, maybe because of generics. |
|
Thanks, it looks good now! @alcaeus this is ready for review now. |
|
Thank you @Ahummeling! 🚀 |
After meeting with @alcaeus we came to the conclusion that it would be best to first implement psr6 compatibility, before moving forward with removing the metadata cache configuration. This pull request is aimed at implementing this compatibility, through means of a compiler pass.
Wanted to get a tiny bit of feedback as I am continuing to figure out which tests cause deprecation triggers, figure out what happens when I install this version in 1 of my projects and all that stuff.
Will be leaving some comments on my first commit to explain certain choices or things that might appear odd