Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fullscreen overlay so the tooltips for the 2 dag toggles show #749

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

NatalieEO
Copy link
Contributor

dockstore/dockstore#1993
I don't think this was being covered by the sidebar anymore? Anyway, fixed the two tooltips not showing in fullscreen mode by adding the overlaycontainer.

Copy link
Collaborator

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, so you do that and it just works? I guess the old days of modifying CSS directly are going away. :)

@NatalieEO
Copy link
Contributor Author

Interesting, so you do that and it just works? I guess the old days of modifying CSS directly are going away. :)

Yeah I wasn't successful messing with the z-index, but found this angular/components#1628 after some googling

@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #749 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #749   +/-   ##
========================================
  Coverage    61.75%   61.75%           
========================================
  Files          268      268           
  Lines         8428     8428           
  Branches       809      807    -2     
========================================
  Hits          5205     5205           
  Misses        3022     3022           
  Partials       201      201
Impacted Files Coverage Δ
src/app/myworkflows/my-services.service.ts 55.55% <0%> (-3.82%) ⬇️
src/app/configuration.service.ts 23.91% <0%> (-0.09%) ⬇️
src/app/shared/auth.model.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc11e4...11ab097. Read the comment docs.

@NatalieEO NatalieEO merged commit e5770bb into develop Aug 22, 2019
@NatalieEO NatalieEO deleted the feature/1993/showToolTips branch August 22, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants