Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(menu): menu doesn't work in full screen mode #1628

Closed
quanterion opened this issue Oct 27, 2016 · 8 comments
Closed

bug(menu): menu doesn't work in full screen mode #1628

quanterion opened this issue Oct 27, 2016 · 8 comments

Comments

@quanterion
Copy link
Contributor

quanterion commented Oct 27, 2016

If I put md-toolbar with md-menu on a div element and go into full screen mode using

var elem = document.getElementById("my-div-id");
if (elem.requestFullscreen) {
  elem.requestFullscreen();
}
else if (elem.webkitRequestFullScreen) {
  elem.webkitRequestFullScreen();
}

then md-menu doesn't show at all

plunker: http://plnkr.co/edit/NCYYbZklZIdYra0xYsfF?p=preview
PS: you should launch it in separate window in order to process fullscreen requests

Environment: Angular 2.0.1 with Material alpha-9-3 using ng-cli
Browsers: latest Chrome & Firefox

@quanterion
Copy link
Contributor Author

quanterion commented Oct 27, 2016

Also the same problems appears with dialog, tooltip - all overlay-based components. It looks like overlay service should be tweaked to support full-screen mode (i.e. temporarily use another ElementRef to inject overlays) since everything outside full-screen div is hidden

@willshowell
Copy link
Contributor

Should be closed via #1949, right?

@jelbourn
Copy link
Member

Yep

@nancy-ly
Copy link

nancy-ly commented Mar 5, 2018

Can this be re-opened? I am still able to reproduce this issue: https://codepen.io/anon/pen/zRXqwm

@quanterion
Copy link
Contributor Author

quanterion commented Mar 5, 2018

@nancy-ly,This is a library for Angular 2 and later, not for Angular 1.x

@arlowhite
Copy link

arlowhite commented Apr 24, 2018

@jelbourn this should be reopened

fullscreen only works in StackBlitz full window view:
https://angular-material2-issue-siqbmy.stackblitz.io

StackBlitz Editor: https://stackblitz.com/edit/angular-material2-issue-siqbmy

@quanterion
Copy link
Contributor Author

you should provide full screen overlay:

{ provide: OverlayContainer, useClass: FullscreenOverlayContainer },

import {
  OverlayContainer,
  FullscreenOverlayContainer
} from '@angular/cdk/overlay';

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants