-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ubuntu-xenial aarch64 Dockerfile #25
Conversation
FYI there is an official Go 1.9 beta binary available for ARM64 now. The project said that if it gets tested by the community they will continue with ARM64 binaries. Given the note above this could be useful for Docker CE etc. |
@alexellis, The new Go 1.9 beta binaries do build docker-ce successfully on aarch64 but we'll be compiling Go 1.8.3 from source until the core team can vet that Go 1.9 doesn't break any functionality. |
I know the Go version is 1.8.x The comment was as an FYI. |
@seemethere it seems that we need to add a dependency there:
|
deb/ubuntu-xenial/Dockerfile.aarch64
Outdated
|
||
ENV GOPATH /go | ||
ENV PATH /go/bin:/usr/src/go/bin:$PATH | ||
ENV DOCKER_BUILDTAGS apparmor pkcs11 seccomp selinux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for pkcs11, see moby/moby@b877fc3#diff-0a5836d551d7f223bdc8b46372ca0089
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated and force pushed, plus rebased off of master
Signed-off-by: Eli Uriegas <[email protected]>
7640713
to
94cbc76
Compare
LGTM |
Signed-off-by: Eli Uriegas [email protected]