Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Links in the labels for project reconstruction #9364

Closed
wants to merge 1 commit into from

Conversation

ulyssessouza
Copy link
Collaborator

What I did
Add Links in the labels for project reconstruction

Related issue
Resolves #9301

(not mandatory) A picture of a cute animal, if possible in relation with what you did

@ulyssessouza ulyssessouza force-pushed the fix-links-not-starting branch from 4b73d67 to c783eb1 Compare April 7, 2022 10:24
@ulyssessouza ulyssessouza requested review from glours and ndeloof April 7, 2022 10:34
@ndeloof
Copy link
Contributor

ndeloof commented Apr 7, 2022

Have you checked dependencies label is already set to include linked services ?
also see #9365 which probably fixes the reported issue

@ulyssessouza
Copy link
Collaborator Author

@ndeloof dependencies label does not include the links. #9365 Also fixes the issue.
But that makes me think about the project that is reconstructed with this missing part... But looks like the commands we reconstruct the project from its containers wouldn't use the links.

@ndeloof
Copy link
Contributor

ndeloof commented Apr 8, 2022

Created #9368 for links not to be considered for dependencies labelling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Compose 2.3.3 does not start subsidiary services called out in links
2 participants