Add Links in the labels for project reconstruction

Signed-off-by: Ulysses Souza <[email protected]>
docker · Apr 7, 2022 · c783eb1 · c783eb1
1 parent 804ef4a
commit c783eb1
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 0 deletions.
diff --git a/pkg/api/labels.go b/pkg/api/labels.go
@@ -51,6 +51,8 @@ const (
 	ImageDigestLabel = "com.docker.compose.image"
 	// DependenciesLabel stores service dependencies
 	DependenciesLabel = "com.docker.compose.depends_on"
+	// LinksLabel stores service links
+	LinksLabel = "com.docker.compose.links"
 	// VersionLabel stores the compose tool version used to run application
 	VersionLabel = "com.docker.compose.version"
 )

diff --git a/pkg/compose/compose.go b/pkg/compose/compose.go
@@ -156,6 +156,14 @@ func (s *composeService) projectFromName(containers Containers, projectName stri
 				service.DependsOn[dependency] = types.ServiceDependency{Condition: condition}
 			}
 		}
+
+		links := service.Labels[api.LinksLabel]
+		if len(links) > 0 {
+			for _, link := range strings.Split(links, ",") {
+				l := strings.Split(link, ":")[0]
+				service.Links = append(service.Links, l)
+			}
+		}
 		project.Services = append(project.Services, *service)
 	}
 SERVICES:

diff --git a/pkg/compose/create.go b/pkg/compose/create.go
@@ -436,6 +436,8 @@ func (s *composeService) prepareLabels(service types.ServiceConfig, number int)
 		dependencies = append(dependencies, s+":"+d.Condition)
 	}
 	labels[api.DependenciesLabel] = strings.Join(dependencies, ",")
+	labels[api.LinksLabel] = strings.Join(service.Links, ",")
+
 	return labels, nil
 }
 

diff --git a/pkg/e2e/fixtures/dependencies/compose.yaml b/pkg/e2e/fixtures/dependencies/compose.yaml
@@ -3,6 +3,12 @@ services:
     image: nginx:alpine
     depends_on:
       - bar
+    links:
+      - bar:first_web
+      - baz:second_web
 
   bar:
     image: nginx:alpine
+
+  baz:
+    image: nginx:alpine
diff --git a/pkg/e2e/start_stop_test.go b/pkg/e2e/start_stop_test.go
@@ -106,6 +106,7 @@ func TestStartStopWithDependencies(t *testing.T) {
 		res := c.RunDockerComposeCmd("-f", "./fixtures/dependencies/compose.yaml", "--project-name", projectName, "up", "-d")
 		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-foo-1  Started"), res.Combined())
 		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-bar-1  Started"), res.Combined())
+		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-baz-1  Started"), res.Combined())
 	})
 
 	t.Run("stop foo", func(t *testing.T) {
@@ -114,19 +115,24 @@ func TestStartStopWithDependencies(t *testing.T) {
 		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-foo-1  Stopped"), res.Combined())
 
 		res = c.RunDockerComposeCmd("--project-name", projectName, "ps", "--status", "running")
+		assert.Assert(t, strings.Contains(res.Combined(), "e2e-start-stop-with-dependencies-baz-1"), res.Combined())
 		assert.Assert(t, strings.Contains(res.Combined(), "e2e-start-stop-with-dependencies-bar-1"), res.Combined())
 		assert.Assert(t, !strings.Contains(res.Combined(), "e2e-start-stop-with-dependencies-foo-1"), res.Combined())
 	})
 
 	t.Run("start foo", func(t *testing.T) {
 		res := c.RunDockerComposeCmd("--project-name", projectName, "stop")
+		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-baz-1  Stopped"), res.Combined())
 		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-bar-1  Stopped"), res.Combined())
+		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-foo-1  Stopped"), res.Combined())
 
 		res = c.RunDockerComposeCmd("--project-name", projectName, "start", "foo")
+		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-baz-1  Started"), res.Combined())
 		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-bar-1  Started"), res.Combined())
 		assert.Assert(t, strings.Contains(res.Combined(), "Container e2e-start-stop-with-dependencies-foo-1  Started"), res.Combined())
 
 		res = c.RunDockerComposeCmd("--project-name", projectName, "ps", "--status", "running")
+		assert.Assert(t, strings.Contains(res.Combined(), "e2e-start-stop-with-dependencies-baz-1"), res.Combined())
 		assert.Assert(t, strings.Contains(res.Combined(), "e2e-start-stop-with-dependencies-bar-1"), res.Combined())
 		assert.Assert(t, strings.Contains(res.Combined(), "e2e-start-stop-with-dependencies-foo-1"), res.Combined())
 	})