-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stop-signal in stack command #388
Conversation
Signed-off-by: Christophe Robin <[email protected]>
6eb321d
to
b129a70
Compare
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 46.14% 45.79% -0.35%
==========================================
Files 193 193
Lines 16073 16070 -3
==========================================
- Hits 7417 7360 -57
- Misses 8269 8324 +55
+ Partials 387 386 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
ping @londoncalling to verify if this needs docs updates |
@thaJeztah , it looks like we have this in the Compose file reference, but currently say it's ignored by Is the first part of this docs update to remove the caveat here re: Regarding Compose CLI support, I assume this warrants a new Compose CLI command topic? |
- What I did
Fixes #370 by passing
StopSignal
to the container spec when doing a deploy.- How I did it
Passed
StopSignal
and removedstop_signal
from unsupported keys.- How to verify it
Create a small
docker-compose
file with a service defining a stop signal, deploy usingdocker stack deploy -c file.yml stack_name
then inspect one of the created containers.- Description for the changelog
Added support for
stop_signal
when deploying a compose file through docker stack.- A picture of a cute animal (not mandatory but encouraged)