Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stop_signal in docker stack deploy #370

Closed
christopherobin opened this issue Jul 21, 2017 · 3 comments
Closed

Add support for stop_signal in docker stack deploy #370

christopherobin opened this issue Jul 21, 2017 · 3 comments

Comments

@christopherobin
Copy link
Contributor

christopherobin commented Jul 21, 2017

Description

stop_signal support was added to swarmkit in docker/swarmkit#1924 and docker in moby/moby#30754 but it is still not supported via docker stack deploy -c compose-file.yml stack_name.

It would be a welcome addition since some of our containers need SIGINT to properly exit.
If it's fine with you guys I could probably do a PR with this functionality.

Steps to reproduce the issue:

  1. Add stop_signal: SIGINT to a docker-compose file
  2. docker stack deploy -c <file> <name>
  3. docker stack scale service=0

Describe the results you received:

The service gets a SIGTERM signal

Describe the results you expected:

The service gets a SIGINT signal

Additional information you deem important (e.g. issue happens only occasionally):

Output of docker version:

Client:
 Version:      17.06.0-ce
 API version:  1.30
 Go version:   go1.8.3
 Git commit:   3dfb8343
 Built:        Sat Jul  8 20:56:41 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.06.0-ce
 API version:  1.30 (minimum version 1.12)
 Go version:   go1.8.3
 Git commit:   02c1d87617
 Built:        Sat Jul  8 22:56:56 2017
 OS/Arch:      linux/amd64
 Experimental: false

Output of docker info:

N/A

Additional environment details (AWS, VirtualBox, physical, etc.):

N/A

@thaJeztah
Copy link
Member

Support for stop-signal was added to services in docker 17.04 through moby/moby#30754, and moby/moby#31091, so this should just be adding the option to the docker-compose file specs and cli

@salzig
Copy link

salzig commented Jan 15, 2019

bildschirmfoto 2019-01-15 um 13 06 10
https://docs.docker.com/compose/compose-file/#not-supported-for-docker-stack-deploy

The Documentation is still telling us another story.

@thaJeztah
Copy link
Member

@salzig thanks! Looks like the documentation side changes never found their way in; see
#388 (comment)

Are you interested in opening a pull request to make that change? There's an "edit this page" link on the top-right of that page in the documentation; that should open an editor on GitHub and you can open a pull-request from that 🤗

eMPee584 added a commit to eMPee584/docker.github.io that referenced this issue Mar 4, 2019
support was added nearly two years ago,
c.f. docker/cli#370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants