Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update docker/docker and moby/sys #2835

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Nov 10, 2020

depends on:

diffs and relevant changes:

docker/docker: moby/moby@c2cc352...0e8023d

  • replace pkg/symlink with github.com/moby/sys/symlink

moby/sys: moby/sys@6154f11...1bc8673

changes:

  • mount, mountinfo: Add support for OpenBSD in addition to FreeBSD
  • mount, mountinfo: Exclude macOS (darwin)
  • mount.RecursiveUnmount(): minor improvements
  • mount.RecursiveUnmount: add a fast path
  • mount: bump mountinfo to v0.3.1
  • mount: Some refactor and improved GoDoc about Windows support
  • mount: use MNT_* flags from golang.org/x/sys/unix on freebsd (reduces use of cgo)
  • mountinfo.Mounted: add fast path for Linux using openat2
  • mountinfo.Mounted: optimize by adding fast paths
  • mountinfo: correctness improvements
  • mountinfo: deprecate PidMountInfo
  • mountinfo: fix not showing package doc, typos
  • mountinfo: fix path unescaping
  • mountinfo: make GetMountinfoFromReader Linux-specific
  • mountinfo: rename FstypeFilter -> FSTypeFilter, fix FilterFunc docs
  • mountinfo: use idiomatic naming for fields
  • Migrate github.com/docker/docker/pkg/symlink

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

Some failures;

cli/command/container/stats.go:159: File is not `goimports`-ed (goimports)

And build failing on macOS;

./scripts/build/cross
Building build/docker-darwin-amd64
# github.com/docker/cli/vendor/github.com/docker/docker/pkg/system
vendor/github.com/docker/docker/pkg/system/rm_unix.go:34:2: undefined: mount.RecursiveUnmount
vendor/github.com/docker/docker/pkg/system/rm_unix.go:68:11: undefined: mount.Unmount
Generating windows resources
Building build/docker-windows-amd64.exe
make: *** [Makefile:43: cross] Error 1

diffs and relevant changes:

docker/docker: moby/moby@c2cc352...af34b94
  - replace pkg/symlink with github.com/moby/sys/symlink

moby/sys: moby/sys@6154f11...1bc8673

changes:
    - mount, mountinfo: Add support for OpenBSD in addition to FreeBSD
    - mount, mountinfo: Exclude macOS (darwin)
    - mount.RecursiveUnmount(): minor improvements
    - mount.RecursiveUnmount: add a fast path
    - mount: bump mountinfo to v0.3.1
    - mount: Some refactor and improved GoDoc about Windows support
    - mount: use MNT_* flags from golang.org/x/sys/unix on freebsd (reduces use of cgo)
    - mountinfo.Mounted: add fast path for Linux using openat2
    - mountinfo.Mounted: optimize by adding fast paths
    - mountinfo: correctness improvements
    - mountinfo: deprecate PidMountInfo
    - mountinfo: fix not showing package doc, typos
    - mountinfo: fix path unescaping
    - mountinfo: make GetMountinfoFromReader Linux-specific
    - mountinfo: rename FstypeFilter -> FSTypeFilter, fix FilterFunc docs
    - mountinfo: use idiomatic naming for fields
    - Migrate github.com/docker/docker/pkg/symlink

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah marked this pull request as ready for review November 10, 2020 21:32
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4c12f1a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2835   +/-   ##
=========================================
  Coverage          ?   57.11%           
=========================================
  Files             ?      297           
  Lines             ?    18645           
  Branches          ?        0           
=========================================
  Hits              ?    10649           
  Misses            ?     7136           
  Partials          ?      860           

@thaJeztah
Copy link
Member Author

@silvin-lubecki @tiborvass PTAL

Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 20.10.0 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants